EMAIL_CC update helpers.py #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMAIL_CC in fir_notifications doesnt work for me. When i added these lines it does. Since iam not Python Dev please review this code. Thank you
formatting
Augustin-FL
requested changes
Aug 1, 2024
There was a problem hiding this comment.
This is by design: EMAIL_CC and EMAIL_BCC are added when emails are sent due to a click on "Alert" or "Takedown" on the web interface (fir_alerting or fir_abuse modules)
They are however not included when sending notification emails.
Shall this behavior be changed, it would be better to edit the file fir_notifications/methods/email.py like this:
params = self.prepare(template, instance)
email_message = prepare_email_message([user.email, ], params['subject'], params['description'],
- request=request)
+ request=request, cc=getattr(settings, 'EMAIL_CC'),
+ bcc=getattr(settings, 'EMAIL_BCC'))
messages.append(email_message)
if len(messages):
connection = mail.get_connection()
added EMAIL_CC and EMAIL_BCC options to fir_notifications plugin
rool back EMAIL_CC because Alert, Takedown feature is impacted too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMAIL_CC in fir_notifications doesnt work for me. When i added these lines it does. Since iam not Python Dev please review this code. Thank you